Skip to content

[Fix]: UInt160.TryParse when source has whitespaces #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

[Fix]: UInt160.TryParse when source has whitespaces #3626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c73d90
fix: UInt160.TryParse when source has whitespaces
nan01ab Dec 15, 2024
4e708a2
Update tests/Neo.UnitTests/UT_UInt160.cs
shargon Dec 16, 2024
83cdaf4
Merge branch 'master' into fix.UInt160-TryParse
shargon Dec 16, 2024
aad21b2
Merge branch 'master' into fix.UInt160-TryParse
Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Neo/UInt160.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public static bool TryParse(string str, out UInt160 result)
var data = new byte[Length];
for (var i = 0; i < Length; i++)
{
if (!byte.TryParse(str.AsSpan(i * 2 + startIndex, 2), NumberStyles.HexNumber, null, out data[Length - i - 1]))
if (!byte.TryParse(str.AsSpan(i * 2 + startIndex, 2), NumberStyles.AllowHexSpecifier, null, out data[Length - i - 1]))
return false;
}
result = new(data);
Expand Down
2 changes: 2 additions & 0 deletions tests/Neo.UnitTests/UT_UInt160.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ public void TestTryParse()
Assert.AreEqual("0x1230000000000000000000000000000000000000", temp.ToString());
Assert.AreEqual(false, UInt160.TryParse("000000000000000000000000000000000000000", out _));
Assert.AreEqual(false, UInt160.TryParse("0xKK00000000000000000000000000000000000000", out _));

Assert.AreEqual(false, UInt160.TryParse(" 1 2 3 45 000000000000000000000000000000", out _));
}

[TestMethod]
Expand Down
Loading