Skip to content

Conversation

@nan01ab
Copy link
Contributor

@nan01ab nan01ab commented Dec 14, 2024

Description

DataCache, SnapshotCache and ClonedCache are under the Persistence/ , but their unit-tests are under IO/Caching/.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nan01ab nan01ab changed the title [Move]: move unit-tests of DataCache to corresponding directory [Move]: move unit-tests of DataCache to corresponding directory Dec 14, 2024
@Jim8y Jim8y requested a review from shargon December 15, 2024 07:32
@NGDAdmin NGDAdmin merged commit 3669912 into neo-project:master Dec 16, 2024
7 checks passed
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nan01ab nan01ab deleted the fix.dir-of-datacache-ut branch December 20, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants