Skip to content

fix plugin download url #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix plugin download url #3329

merged 1 commit into from
Jun 14, 2024

Conversation

@Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jun 11, 2024 •
edited
Loading

Description

This pr fixes the neo plugin download url

Fixes # (issue)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y requested review from NGDAdmin and superboyiii June 11, 2024 08:15
@Jim8y Jim8y mentioned this pull request Jun 11, 2024
Closed
6 tasks
AnnaShaleva
AnnaShaleva approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are releasing 3.7.4 with modules from monorepo, right?

@Jim8y
Copy link
Contributor Author

Jim8y commented Jun 11, 2024 •
edited
Loading

We are releasing 3.7.4 with modules from monorepo, right?

@AnnaShaleva No, from its original repo. This pr is not in a hurry. 3.7.5 will be based on the branch of 3.7.4, with only those few bug fix prs.

@NGDAdmin NGDAdmin merged commit ef77a4c into neo-project:master Jun 14, 2024
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 14, 2024
@Jim8y
Merge branch 'master' into mock-rpcserver-test
9b238ec 
* master:
  Fixed pathing and Property (neo-project#3306)
  [Neo CLI New Feature] Allow custom plugins (neo-project#3295)
  Return expect to verify neo-cli (neo-project#3318)
  [Neo CLI Optimization] fix exception message (neo-project#3314)
  fix plugin download url (neo-project#3329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@vncoelho vncoelho vncoelho approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@NGDAdmin NGDAdmin Awaiting requested review from NGDAdmin

@superboyiii superboyiii Awaiting requested review from superboyiii

@cschuchardt88 cschuchardt88 Awaiting requested review from cschuchardt88

Assignees

No one assigned

Labels

Ready to Merge Waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jim8y @shargon @vncoelho @roman-khimov @AnnaShaleva @NGDAdmin