Reduce json max depth default value #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
if (!IsHardforkEnabled(Hardfork.HF_Basilisk)) maybe LOL, kinda allegic to the change now. |
Contributor
|
Member
|
Hahahaha This change is necessary because of the limit, anyway. I do not believe it solves the issue. |
Closed
Member
Author
|
@superboyiii could you test it? I think that no HF will be needed |
Member
Sure |
superboyiii
approved these changes
Sep 25, 2023
Member
superboyiii
left a comment
superboyiii
left a comment
There was a problem hiding this comment.
Tested OK. Data is compatible. @shargon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2950
The default value of
JsonReaderOptions.MaxDepthis 64 as mentioned in:We shouldn't have more than that