Neo v3.4.0 Checklist

[superboyiii]

Now We're making the checklist of neo v3.4.0 for release preparation. We plan to release v3.4.0 ASAP then upgrade both testnet and mainnet. It's a hotfix version which should be applied ASAP.

Mandatory issues

• Contract with out-of-script-bounds method offset is allowed to be deployed #2767
• Add committee change events #2763
• Strange logic about the default seed node #2772 (optional)

Mandatory PRs

• Disallow out-of-bounds method neo-vm#476
• Sync Neo.VM 3.3.1-CI00321 #2786
• Add name/symbol/decimals to GetNep17Balances neo-modules#738
• Fix argument name in Nep17API.cs neo-modules#740
• Fix nep11 tracker neo-modules#741
  Add committee change events #2764 (postponed)
  Remove unnecessary default seedlist #2773 (postponed)
• Add Has Method #2781
• correct typos, comments #2785
• Rename projects #2790
  remove tx fee neo-modules#743 (denied)
• Move Neo.Json into a separate project #2791
• Rename projects #2790
• 3.4.0 neo-modules#744
• Remove Oracle Request #2795
• Improve ApplicationEngine #2796

@neo-project/core @neo-project/developers @neo-project/ngd-seattle

[roman-khimov]

neo-project/neo-modules#741, please.

[ixje]

These please
#2763
#2772

[superboyiii]

neo-project/neo-modules#741, please.

Added.

[superboyiii]

These please #2763 #2772

I take #2772 as optional since it hasn't achieved agreement.

[ixje]

I take #2772 as optional since it hasn't achieved agreement.

I'm trying to keep it warm/going. Currently we're waiting for the NEO team

[devhawk]

Will #2763 / #2764 require a resync?

If so, between resync and the VM updates, maybe this should be v3.4 not v3.3.2?

[devhawk]

Also, neo-project/neo-modules#741 is a breaking change (righteous, but still breaking). So I think we need to bump the minor version for this update

My bad, didn't realize this was an addition not a change

[superboyiii]

My bad, didn't realize this was an addition not a change

But I think #2781 need resync.

[roman-khimov]

Now that we have #2795, it's important enough to me to be a part of the release. But then the only thing left is neo-project/neo-modules#743 (and technical updates like neo-modules#744) and we need to push this thing out. It's three weeks already since this issue was created and we wanted to release ASAP. There are important fixes there and holding them in the queue doesn't help anyone.

[superboyiii]

Now that we have #2795, it's important enough to me to be a part of the release. But then the only thing left is neo-project/neo-modules#743 (and technical updates like neo-modules#744) and we need to push this thing out. It's three weeks already since this issue was created and we wanted to release ASAP. There are important fixes there and holding them in the queue doesn't help anyone.

Yes, agree.

[superboyiii]

@roman-khimov We'll release v3.4.0 whenever #2795 and #2796 are merged.