-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade react-scripts from 4.0.1 to 4.0.3 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3. See this package in npm: react-scripts See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/29adeb13-c4eb-4415-a5ea-c03bbd0957c1?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated security update, initiated by Snyk, aimed at improving the project's overall security posture. It focuses on updating a critical development dependency to resolve a comprehensive list of known vulnerabilities, ensuring the application benefits from the latest security patches and improvements.
Highlights
- Dependency Upgrade: This pull request upgrades the
react-scriptsdependency from version4.0.1to4.0.3. - Security Vulnerability Resolution: The upgrade addresses a significant number of identified security vulnerabilities, including several high-severity issues such as Remote Memory Exposure, Improper Input Validation, Prototype Pollution, and Server-side Request Forgery (SSRF), as well as various medium and low-severity concerns.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades react-scripts from version 4.0.1 to 4.0.3. This is a patch update that addresses a number of security vulnerabilities, including one critical vulnerability.
The change is correct and beneficial. I've added a comment on package.json with two recommendations:
- To change the version specifier to
^4.0.3to automatically receive future non-breaking security patches. - To plan a follow-up upgrade to
[email protected]to resolve other known vulnerabilities and keep the project up-to-date, which will also require upgrading React itself.
After applying the change, please remember to run npm install to update package-lock.json and commit the result.
| "react": "^17.0.1", | ||
| "react-dom": "^17.0.1", | ||
| "react-scripts": "4.0.1" | ||
| "react-scripts": "4.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing these vulnerabilities. This upgrade from 4.0.1 to 4.0.3 is a good step as it resolves several security issues, including a critical one.
I have two suggestions for further improvement:
-
Use a caret
^for the version: To automatically get non-breaking security patches in the future, it's a good practice to use a caret^for the version specifier, similar toreactandreact-domin this file. This would change"4.0.3"to"^4.0.3". -
Plan an upgrade to version 5:
[email protected]is still outdated and has known vulnerabilities (e.g., those fixed in5.0.1). I strongly recommend planning a follow-up to upgrade to[email protected]. This is a major version bump and will require upgradingreactandreact-domto v18, but it's crucial for security and maintainability.
For this PR, I'd suggest applying the first point.
"react-scripts": "^4.0.3"
Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 2 versions ahead of your current version.
The recommended version was released 4 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-DNSPACKET-1293563
SNYK-JS-URLPARSE-2407770
SNYK-JS-IMMER-1019369
SNYK-JS-IP-6240864
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-ASYNC-2441827
SNYK-JS-BODYPARSER-7926860
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-REACTDEVUTILS-1083268
SNYK-JS-EVENTSOURCE-2823375
SNYK-JS-EXPRESS-6474509
SNYK-JS-EXPRESS-7926867
SNYK-JS-FOLLOWREDIRECTS-2332181
SNYK-JS-URLPARSE-1078283
SNYK-JS-URLPARSE-1533425
SNYK-JS-URLPARSE-2401205
SNYK-JS-URLPARSE-2407759
SNYK-JS-FOLLOWREDIRECTS-6444610
SNYK-JS-URLPARSE-2412697
SNYK-JS-COOKIE-8163060
SNYK-JS-FOLLOWREDIRECTS-2396346
SNYK-JS-SERVESTATIC-7926865
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-SEND-7926862
Release notes
Package name: react-scripts
-
4.0.3 - 2021-02-22
-
4.0.2 - 2021-02-03
-
4.0.1 - 2020-11-23
from react-scripts GitHub release notesImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: