-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @testing-library/jest-dom from 5.14.1 to 5.17.0 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.14.1 to 5.17.0. See this package in npm: @testing-library/jest-dom See this project in Snyk: https://app.snyk.io/org/mohammadnewton/project/8205fad6-188e-46ed-bb29-c5bad44a0be4?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've opened this pull request to upgrade the @testing-library/jest-dom dependency. This is an automated update initiated by Snyk to ensure our project's dependencies are kept current, which helps in maintaining security and simplifying future vulnerability management.
Highlights
- Dependency Upgrade: I've updated @testing-library/jest-dom from version 5.11.4 to 5.17.0. This is a significant jump covering multiple minor and patch releases.
- New Feature: Version 5.17.0 introduces a new matcher, toHaveAccessibleErrorMessage, which provides a better implementation of the accessibility specification. The older toHaveErrorMessage matcher has been deprecated.
- Bug Fixes and Improvements: This upgrade also incorporates various bug fixes and minor improvements from intermediate versions, such as migrating CSS tools, supporting unenclosed inner text for details elements, and improving error messages for matchers like toHaveClass.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades @testing-library/jest-dom
to version 5.17.0
. This is a welcome update. Please note that this new version deprecates the toHaveErrorMessage
matcher in favor of toHaveAccessibleErrorMessage
. I've added a comment with details. I also recommend reviewing other dependencies, as several seem to be outdated, which could pose future maintenance and security risks.
"json-server": "^0.16.3", | ||
"@learn-co-curriculum/jest-learn-reporter": "^0.1.0", | ||
"@testing-library/jest-dom": "^5.11.4", | ||
"@testing-library/jest-dom": "^5.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to @testing-library/[email protected]
deprecates the toHaveErrorMessage
matcher in favor of toHaveAccessibleErrorMessage
. Using the old matcher will now result in deprecation warnings during test runs. It is recommended to migrate any usage of toHaveErrorMessage
to the new matcher to stay aligned with the library's updates and accessibility best practices.
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.14.1 to 5.17.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 9 versions ahead of your current version.
The recommended version was released 2 years ago.
Release notes
Package name: @testing-library/jest-dom
5.17.0 (2023-07-18)
Features
toHaveAccessibleErrorMessage
better implementing the spec, deprecatetoHaveErrorMessage
(#503) (d717c66)5.16.5 (2022-08-04)
Bug Fixes
5.16.4 (2022-04-05)
Bug Fixes
5.16.3 (2022-03-24)
Bug Fixes
.not
(#447) (6988a67)5.16.2 (2022-02-03)
Bug Fixes
toBeDisabled
(#368) (8162115)5.16.1 (2021-12-06)
Bug Fixes
toHaveClass
error message format (#405) (a9beb47)5.16.0 (2021-12-03)
Features
5.15.1 (2021-11-23)
Bug Fixes
5.15.0 (2021-11-02)
Features
5.14.1 (2021-06-11)
Bug Fixes
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: