Improve context cancellation performance. #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #247 (reply in thread)
This currently just adds a (micro) benchmark to measure the problem.
Results:
Interpreting results:
offis disabling progress reporting by commenting thisc.call("sqlite3_progress_handler_go", ...)noctxis passing an non-cancellable context, which skips much ofSetInterrupt, andGosched, with cheapDone/Errimplementationsnoschedjust commentsGosched(but there are still mutexes/atomics onDone/Err)tipis where we currently stand with a cancellable context1000is changing the frequency of the callback from 100 to 1000