Skip to content

EC2 facade: handle snapshot not found #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

EC2 facade: handle snapshot not found #1708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ScoutSuite/providers/aws/facade/ec2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import asyncio
import base64
import boto3
from botocore.exceptions import ClientError
import zlib

from ScoutSuite.core.console import print_exception, print_warning
Expand Down Expand Up @@ -155,11 +156,13 @@ async def _get_and_set_snapshot_attributes(self, snapshot: {}, region: str):
snapshot['CreateVolumePermissions'] = await run_concurrently(lambda: ec2_client.describe_snapshot_attribute(
Attribute='createVolumePermission',
SnapshotId=snapshot['SnapshotId'])['CreateVolumePermissions'])
except Exception as e:
if 'NotFound' in e:
except ClientError as e:
if e.response["Error"]["Code"] == "InvalidSnapshot.NotFound":
print_warning(f'Failed to describe EC2 snapshot attributes: {e}')
else:
print_exception(f'Failed to describe EC2 snapshot attributes: {e}')
except Exception as e:
print_exception(f'Failed to describe EC2 snapshot attributes: {e}')

async def get_network_acls(self, region: str, vpc: str):
filters = [{'Name': 'vpc-id', 'Values': [vpc]}]
Expand Down
Loading