Skip to content

Conversation

@chopeen
Copy link

@chopeen chopeen commented Jun 5, 2024

Description

Azure region names are case insensitive (i.e. global, not Global). This is different for display names, but they are not used here.

This PR fixes the condition log_alert.location == 'Global' and additionally makes case insensitive.

Fixes #1644

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@chopeen chopeen changed the base branch from master to develop June 5, 2024 11:47
@hsource
Copy link

hsource commented Sep 6, 2024

I've verified this is an issue that affects us as well and should be merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checking Azure alert is failing because 'global' location name is lowercase

2 participants