Skip to content

Conversation

@ncc-akis
Copy link
Contributor

Description

The rule was not being fired because the raw_vault.properties.enable_purge_protection property was set to None rather than False by the Azure SDK. Because, in Python, False or None evaluated to None rather than False, this was interfering with the subsequent evaluation of the rule and the display of the value in the report.

Also, I have spotted some errors in the finding template which I fixed.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@fernando-gallego fernando-gallego self-assigned this Jul 3, 2023
@fernando-gallego fernando-gallego merged commit 00ab346 into nccgroup:develop Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants