Bugfix/false negative keyvault purge protection #1549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rule was not being fired because the
raw_vault.properties.enable_purge_protectionproperty was set to None rather than False by the Azure SDK. Because, in Python,False or Noneevaluated toNonerather thanFalse, this was interfering with the subsequent evaluation of the rule and the display of the value in the report.Also, I have spotted some errors in the finding template which I fixed.
Type of change
Select the relevant option(s):
Checklist: