Fix(gcp): update cloudsql api and edge case configurations #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an app is not accessible with an http url, we have a false positive on th http exposure
If we have no environment variable on cloud function AttributeError: 'NoneType' object has no attribute 'items' in get_environment_secrets function
saez0pub
changed the title
|
Great find; give us some time to look at please! |
|
LGTM |
|
I should have Google'd https://cloud.google.com/logging/docs/reference/audit/appengine/rest/Shared.Types/SecurityLevel |
liyun-li
approved these changes
Jun 5, 2023
| function_dict['docker_registry'] = raw_function['dockerRegistry'] | ||
| function_dict['url'] = raw_function.get('httpsTrigger', {}).get('url') | ||
| function_dict['security_level'] = raw_function.get('httpsTrigger', {}).get('securityLevel') | ||
| function_dict['security_level'] = 'SECURE_ALWAYS' if function_dict['url'] is None else raw_function.get('httpsTrigger', {}).get('securityLevel') |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(gcp): None as cloudfunctions environment_variables
If we have no environment variable on cloud function
AttributeError: 'NoneType' object has no attribute 'items'
in get_environment_secrets function
fix(gcp): False positive on pubsub only cloud functions
If an app is not accessible with an http url, we have a false positive
on the http exposure
fix(gcp): gke cluster subnetwork can be cross project
fix(gcp): sql-component api is deprecated
See https://cloud.google.com/sql/docs/mysql/admin-api/rest
Type of change
Select the relevant option(s):
Checklist: