Skip to content

Conversation

@liyun-li
Copy link
Contributor

@liyun-li liyun-li commented Oct 6, 2022

Description

Fixes #1465 and #1463

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

Remove the assumption that all Secrets have a `data` field.
Remove the assumption the `data` field in every Secret is a dictionary.
This typing seems to have caused some compatibility issues.
@michyweb michyweb merged commit 6563ac8 into nccgroup:develop Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants