Update Makefile to use new docker compose syntax #2746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Aligns the Makefile with the latest Docker CLI by replacing deprecated docker-compose invocations with the integrated docker compose syntax.
- Updated
start-servicestarget to usedocker compose up -d - Updated
stop-servicestarget to usedocker compose down
Comments suppressed due to low confidence (1)
Makefile:270
- [nitpick] Update the comment to reflect the new CLI syntax (e.g., change
docker-composetodocker compose) for consistency.
start-services: #-- Start development services with docker-compose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Makefileto align with the latest Docker CLI syntax. The changes replace the deprecateddocker-composecommand with the newerdocker composecommand.docker-composewithdocker composefor starting development services in thestart-servicestarget. (Makefile, MakefileL271-R275)docker-composewithdocker composefor stopping development services in thestop-servicestarget. (Makefile, MakefileL271-R275)