Add check_positive_decimal correctness function #2736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
check_positive_decimal
in crates/core/src/correctness.rs to enforce thatrust_decimal::Decimal
parameters are strictly positive. The helper replaces hand-rolled checks insidevalidate_instrument_common
, tightening validation for fields such asmargin_init
. Comprehensive rstest cases cover positive, zero, and negative edge conditions.Impact
Non-breaking: only invalid (≤ 0) decimal inputs now fail early with a clear error message, improving safety while leaving existing valid workflows unchanged.
Notes
#[inline(always)]
hint.correctness
andmodel::instruments
modules.