Skip to content

Refine Rust catalog #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

Refine Rust catalog #2734

merged 1 commit into from
Jun 29, 2025

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Jun 23, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

Summary

  • Add pyo3 query functions actually returning data
  • Add consolidate_catalog_by_period to rust catalog
  • Moved catalog operations functions like consolidate and reset file names to catalog_operations.rs
  • Improved catalog testing in rust and python
  • Improved catalog documentation

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@faysou faysou marked this pull request as draft June 23, 2025 22:23
@faysou faysou force-pushed the consolidate_period_rust branch from faceddd to 9b46081 Compare June 24, 2025 22:15
@faysou faysou marked this pull request as ready for review June 24, 2025 22:29
@faysou faysou force-pushed the consolidate_period_rust branch 5 times, most recently from e886c21 to 3915b3f Compare June 28, 2025 00:13
@faysou faysou force-pushed the consolidate_period_rust branch from 3915b3f to 0550013 Compare June 28, 2025 21:02
@cjdsellers cjdsellers changed the title Refine rust catalog Refine Rust catalog Jun 29, 2025
@cjdsellers cjdsellers merged commit acaef85 into develop Jun 29, 2025
13 checks passed
@cjdsellers cjdsellers deleted the consolidate_period_rust branch June 29, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants