Skip to content

Refine catalog #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Refine catalog #2720

merged 1 commit into from
Jun 18, 2025

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Jun 18, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • Renamed instrument_ids to identifiers in python catalog functions
  • Removed hard coded s3 code in rust catalog and made it more general so it works with other storage providers

Summary

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@faysou faysou force-pushed the catalog_improvements branch 2 times, most recently from e041454 to 4408949 Compare June 18, 2025 11:05
@faysou faysou force-pushed the catalog_improvements branch from 4408949 to 0971b8d Compare June 18, 2025 12:55
@cjdsellers cjdsellers merged commit e948623 into develop Jun 18, 2025
13 checks passed
@cjdsellers cjdsellers deleted the catalog_improvements branch June 18, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants