Skip to content

Add submit order list support for sandbox #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

petioptrv
Copy link
Collaborator

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

Summary

This PR adds support for submitting order lists when using the sandbox execution client.

Related Issues/PRs

N/A

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

I attempted to add a unit test in the tests/integration_tests/adapters/sandbox/test_execution.py file, however, the current unit tests around sandbox execution are WIP, so I am not sure if my test case makes sense.

@petioptrv
Copy link
Collaborator Author

@cjdsellers, please take a look at my test case. I know that the first throwaway event is the initialization of the order, but what about the subsequent ones? Also, would they be group by event (as I have them now) or by order?

@cjdsellers
Copy link
Member

Hi @petioptrv

Thanks for the contribution and good catch!

The anatomy of the test looks fine to me. If the test actually passes then its fine to unskip, otherwise if there is some obscure error you can't figure out then we can just merge and I'll have a look locally.

@petioptrv
Copy link
Collaborator Author

@cjdsellers, I thought the issue I was seeing earlier was obscure, but on second glance, it now works, and I unskipped the previous test as well, since it passes too.

@cjdsellers cjdsellers changed the title Feat/submit order list sandbox Add submit order list support for sandbox Jun 16, 2025
@cjdsellers cjdsellers merged commit 253fdce into nautechsystems:develop Jun 16, 2025
12 checks passed
@petioptrv petioptrv deleted the feat/submit-order-list-sandbox branch July 21, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants