Add create function to kv store
#1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenperera
force-pushed
the
feature/kv-create
branch
from
17bff07 to
7865c71
Compare
praveenperera
force-pushed
the
feature/kv-create
branch
from
309dd9b to
e88df36
Compare
Member
|
Thank you for the PR! |
Jarema
requested changes
Feb 5, 2024
Member
Jarema
left a comment
Jarema
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Looks good. Just one comment around error Display impl.
Jarema
force-pushed
the
feature/kv-create
branch
from
ed38fa7 to
f19fc55
Compare
Jarema
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1204