Do asynchronous DNS lookups in ServerAddr::socket_addrs
#1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
approved these changes
Jan 6, 2024
Member
Jarema
left a comment
Jarema
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for catching and fixing this @paolobarbolini !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
ServerAddr::socket_addrswas blocking the tokio runtime because it used the std blocking implementation for doing DNS lookups. This switches to thetokioimplementation, which internally does aspawn_blockingof the std call.