Fix Service::stop #1160
Merged
Fix Service::stop #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR! |
There were 2 issues in the stop system for services : - On the first poll of the stream, the shutdown future was not polled, thus stopping the service would never wake this task - After the shutdown future is resolved, the next poll will still poll the shutdown future, which is not allowed
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
approved these changes
Nov 13, 2023
Member
Jarema
left a comment
Jarema
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for your contribution!
I added a test that does not work with while let Some to test this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 issues in the stop system for services :