Always log Events
#1123
Merged
Always log Events
#1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobarbolini
force-pushed
the
always-trace
branch
from
20389e2 to
febba31
Compare
paolobarbolini
force-pushed
the
always-trace
branch
from
febba31 to
f0c4071
Compare
Jarema
approved these changes
Nov 15, 2023
Member
Jarema
left a comment
Jarema
left a comment
There was a problem hiding this comment.
Yes, I agree, that makes sense.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an allocation from the
Boxing of theFuturereturned by the event handler closure and makes it always trace the event, which makes much more sense to me.