Skip to content

Updates for Svc/DpWriter corresponding to UT cmake udpate for protected/private #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

m-aleem
Copy link
Collaborator

@m-aleem m-aleem commented Jun 24, 2025

Related Issue(s) #3446
Has Unit Tests (y/n) Yes - Existing
Documentation Included (y/n) N/A

Change Description

I locally updated fprime/cmake/settings.cmake to change -DPROTECTED=protected -DPRIVATE=private. This causes additional build errors beyond all our updates in manual code for PRIVATE->private and PROTECTED->protected due to auto-coded files which use PRIVATE, PROTECTED. This set of changes is associated with fixing Svc/DpWriter so that the UTs in this directory can build and pass.

Approach in this case was:

  1. Add accessor methods to DpWriterTester

Rationale

#3446

Future Work

  1. Note that this PR does not include the update to fprime/cmake/settings.cmake itself - this will be done at the end
  2. Note that this PR does not include re-naming the flight code Impl to (separate issue)

@m-aleem m-aleem requested a review from LeStarch June 24, 2025 21:50
@m-aleem m-aleem marked this pull request as ready for review June 24, 2025 21:50
@LeStarch LeStarch merged commit 048e80c into nasa:devel Jun 25, 2025
51 checks passed
@m-aleem m-aleem deleted the devel-3446-ah-v2 branch June 25, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants