Skip to content

Update to Qt 6.2.11 on Windows only #26167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

Update to Qt 6.2.11 on Windows only #26167

merged 1 commit into from
Jan 27, 2025

Conversation

@cbjeukendrup
Copy link
Member

@cbjeukendrup cbjeukendrup commented Jan 20, 2025 •
edited
Loading

Counterpart of #24969

@cbjeukendrup cbjeukendrup changed the title Update to Qt 6.2.11 Update to Qt 6.2.11 on Windows only Jan 20, 2025
@cbjeukendrup cbjeukendrup marked this pull request as ready for review January 20, 2025 13:08
@DmitryArefiev
Copy link
Contributor

@zacjansheski Can you check it on your side too please (Windows only)?

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Jan 23, 2025 •
edited
Loading

@cbjeukendrup Comparing with master (qt6.2.4), I found one bug (for now). I can't drag dynamics with mouse from the first attempt (click+hold+drag)

bandicam.2025-01-23.15-12-59-672.mp4

Can you prepare a PR with qt6.2.9 please? If the bug doesn't occur there, we should move to 6.2.9 version only.
(or you can check it briefly without doing PR on your environment)

@cbjeukendrup
Copy link
Member Author

@DmitryArefiev I tried in my local Qt 6.2.9 build, and unfortunately it has the same problem...

Schermopname.2025-01-23.om.16.25.52.mov

@DmitryArefiev
Copy link
Contributor

@DmitryArefiev I tried in my local Qt 6.2.9 build, and unfortunately it has the same problem...
Schermopname.2025-01-23.om.16.25.52.mov

@cbjeukendrup Hmm.. OK. Do you have a feeling that 6.2.11 could be better than 6.2.9?

@cbjeukendrup
Copy link
Member Author

They say that 6.2.10 fixes about 160 bugs with respect to 6.2.9, and 6.2.11 fixes 95 bugs compared to 6.2.10. That number The impact is probably less significant than that number suggests, because of course we may not have suffered at all from the bugs they fixed. So I don't feel strongly about it either way. But I'd say, if we can't find things that are worse in 6.2.11 than in 6.2.9, then let's go with 6.2.11, perhaps those mystery bug fixes are beneficial.

@DmitryArefiev
Copy link
Contributor

OK! Let's merge it and try 6.2.11

@DmitryArefiev DmitryArefiev merged commit 559bf1e into musescore:master Jan 27, 2025
11 checks passed
@DmitryArefiev DmitryArefiev mentioned this pull request Jan 29, 2025
Open
4 tasks
@cbjeukendrup cbjeukendrup deleted the qt_6.2.11 branch January 30, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorkorsukov igorkorsukov igorkorsukov approved these changes

Assignees

@zacjansheski zacjansheski

@DmitryArefiev DmitryArefiev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbjeukendrup @DmitryArefiev @igorkorsukov @zacjansheski