Skip to content

Conversation

@cbjeukendrup
Copy link
Member

@cbjeukendrup cbjeukendrup commented Sep 11, 2024

On macOS, it causes a problem with disappearing texts, which will take more time to fix. Also, the issues solved by this update affect other OSs more than macOS.

Resolves only on Windows: #23505
Resolves not yet: #23970
Resolves: #24232
Resolves: #24579
Resolves only on Windows: #24667

May solve some blank screen issues too (https://musescore.org/en/node/368527#comment-1257820)

@cbjeukendrup cbjeukendrup changed the base branch from 4.4.2 to 4.4.3 September 16, 2024 09:47
@cbjeukendrup cbjeukendrup force-pushed the port/4.4.3/qt_6.2.9_except_macOS branch from 658b7c0 to a755a89 Compare September 17, 2024 10:35
@cbjeukendrup
Copy link
Member Author

@DmitryArefiev This PR doesn't touch anything on macOS, so only Windows and Linux need to be tested.

@DmitryArefiev
Copy link
Contributor

@cbjeukendrup Tested on Win10, LinuxUbuntu22.04
#23505 looks good
#24232 and #24579 - I can't check it properly because was not able to reproduce it before

For now, I found one UI regression: when moving cursor, the highlight disappears in the middle of item (File menu, Context menu):

bandicam.2024-09-17.18-24-00-369.mp4

On macOS, it causes a problem with disappearing texts, which will take more time to fix. Also, the issues solved by this update affect other OSs more than macOS.

Resolves only on Windows: musescore#23505
Resolves not yet: musescore#23970
Resolves: musescore#24232
Resolves: musescore#24579
@cbjeukendrup cbjeukendrup force-pushed the port/4.4.3/qt_6.2.9_except_macOS branch from a755a89 to e16745e Compare September 22, 2024 19:49
@cbjeukendrup
Copy link
Member Author

@DmitryArefiev That turned out to be another Qt bug, but fortunately I could apply a workaround that hopefully works and doesn't break anything else.

Relevant Qt commits:
- broken in qt/qtdeclarative@499828b
- perhaps changed a bit in qt/qtdeclarative@205e31d, but not fixed

Qt commit that seemed relevant at first, but didn't turn out to be:
- qt/qtdeclarative@cdc0e5c
@DmitryArefiev
Copy link
Contributor

@DmitryArefiev That turned out to be another Qt bug, but fortunately I could apply a workaround that hopefully works and doesn't break anything else.

@cbjeukendrup Yeah, that works well now. I will do a smoke test and get back with results tomorrow

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Sep 26, 2024

Tested on Win10, Mac13.6, LinuxUbuntu22.04.1 LTS
#23505 looks good
#24232 and #24579 - I can't check it properly because was not able to reproduce it before


@cbjeukendrup
On Windows, I found a minor regression. On 125% scaling, there a white outline flickering when scrolling through expanded palettes.

bandicam.2024-09-26.14-23-32-037.mp4

On Linux, there is much serious regression . Crash when open color picker in Properties (#24173) and crash when open file browser (when open Save dialog for new score or Save As dialog or Save As in Export dialog)

Screencast.from.2024-09-26.14-21-33.mp4

@MarcSabatella
Copy link
Contributor

Is your Linux test using xcb or wayland? For me, the color picker doesn't work correctly on wayland in 4.4.2 anyhow - see my comment in #24173 (comment).

@DmitryArefiev
Copy link
Contributor

Is your Linux test using xcb or wayland? For me, the color picker doesn't work correctly on wayland in 4.4.2 anyhow - see my comment in #24173 (comment).

@MarcSabatella I'm on LinuxUbuntu22.04.1 LTS with Wayland (GNOME Version 46)

And the color picker works fine in 4.4.2 and 4.4.3 builds

@cbjeukendrup
Copy link
Member Author

See #24969; I created a new PR for Windows only, because it's convenient if the Linux artifacts still stay available.

@cbjeukendrup cbjeukendrup deleted the port/4.4.3/qt_6.2.9_except_macOS branch February 27, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants