Another attempt at fixing the popup memory leak #23495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
Jul 8, 2024
|
@cbjeukendrup maybe your fix will also help to solve this problem? |
This was referenced Jul 8, 2024
Closed
|
@zacjansheski Have you also verified that there are no regressions with #22640 and #22641? (As mentioned in the description, this PR reapplies a commit that previously caused those issues, and thus had to be reverted as a hotfix, but now after reapplying the commit, I made a proper fix for one issue and can't reproduce the other.) |
|
@cbjeukendrup Yes, I checked and those issues did not return |
|
Awesome! Let's merge it then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22885
Essentially just reapplying 2fa36e3.
However, this time I attempted to do it without re-causing #22640, and for me on macOS it seems to work.
I also couldn't reproduce #22641 again, but I didn't do anything special for that, so that's a bit more scary.
It turns out that the memory leak issue is a sort of blocker for #18436. That PR crashes because the popup window stays alive even after the popup has been closed, and thus the popup content and model stay alive too, and the latter causes crashes because it contains pointers to deleted items. That can be patched in other ways, but fixing the memory leak problem would be the cleanest way. That was the main motivation for re-trying this right now.