Refactor stem length adjustment calculations for beams #21606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
requested review from
RomanPudashkin,
its-not-nice and
mike-spa
mike-spa
approved these changes
Feb 22, 2024
its-not-nice
approved these changes
Feb 22, 2024
Contributor
|
Is line 25 in |
cbjeukendrup
force-pushed
the
french_beams_refactor
branch
from
280c139 to
f60bfa9
Compare
Member
Author
There are still other usages of std::set in that file, so I'll leave the include there. (It isn't strictly necessary because it's also in the precompiled header file ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a chance that this makes it slightly more efficient.
(a sequel of #21126)