Updated pin view #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrough the every time user presses a key. The parent must now provide the value to the component through the setting - see the README for example.
muromec
reviewed
Aug 1, 2017
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Please, remove ide-specific file from commit.
muromec
reviewed
Aug 1, 2017
|
|
||
| Required options: | ||
| * Pincode (`pinCode`) - this is the value displayed and modified by the `Pin` component | ||
| * Callback method (`onPinEntered(value)`) - this is called for everytime the use touches the keyboard (except when a digit is pressed and the `pinLength` has been reached) |
There was a problem hiding this comment.
Please, rename props to value and onChange.
Upgrade to RN 0.46.4 gives warning
muromec
requested changes
Sep 7, 2017
| render() { | ||
| // Extract props | ||
| const pinCode = this.props.pinCode; | ||
| const pinLength = this.props.pinLength ? this.props.pinLength : this.defaultProps.pinLength; |
There was a problem hiding this comment.
Since you fixed defaultProps defintion, you can simply do like this:
const {pinCode, pinLength, prompt} = this.props;
| const dots = makeDots(pinLength - pinCode.length); | ||
|
|
||
| // Build buttons | ||
| const clearButton = this.buildButton(clearVisible, "Clear", () => this.doClear()); |
There was a problem hiding this comment.
Please, explicitly bind event handlers to this in constructor (not in render function). Something like this would do:
constructor(props) { super(props); this.handleClear = this.handleClear.bind(this); }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a some updates to the
Pincomponent to make it more usable, at least for our purposes :)Hope you will like them and like to merge to them.