fix: don't panic on non minimal varints #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a varint it non-minimally encoded in a no_std environment, don't panic, but return an error. Also some minor Clippy warnings were fixed. Fixes #282.
mattheworris
approved these changes
Apr 13, 2023
| #[test] | ||
| fn decode_non_minimal_error() { | ||
| // This is a non-minimal varint. | ||
| let data = [241, 0, 0, 0, 0, 0, 128, 132, 132, 132, 58]; |
There was a problem hiding this comment.
Just another data point, here's the data that we found from fuzz testing that caused the panic:
let data = [0, 1, 0, 1, 203, 155, 0, 0, 0, 5, 67];
Comment on lines
+366
to
+368
| return decode::u64(&b[..=i]) | ||
| .map(|decoded| decoded.0) | ||
| .map_err(Error::Varint); |
There was a problem hiding this comment.
I tested this change with our project and it fixes the panic, Thanks!
mxinden
approved these changes
Apr 14, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
With my limited knowledge of rust-multihash, this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a varint it non-minimally encoded in a no_std environment, don't panic, but return an error.
Also some minor Clippy warnings were fixed.
Fixes #282.