[pickers] Cleanup PageUp and PageDown event handlers on time components
#14928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurbalduini
added
performance
scope: pickers
|
Deploy preview: https://deploy-preview-14928--material-ui-x.netlify.app/ |
arthurbalduini
changed the title
getFocusedListItemIndex functionPageUp and PageDown support on time components
LukasTy
changed the title
PageUp and PageDown support on time componentsPageUp and PageDown event handlers on time components
LukasTy
approved these changes
Oct 14, 2024
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
LGTM. 👍
I've adjusted the PR title to avoid talking about performance, when the difference will not be perceivable to anyone. 🙈
Member
|
Nice, I would be curious to see the bundle size save this has, we would need to first setup #5550. We had a thread with @Janpot about listRef.current! too in mui/material-ui#43939 (comment). |
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this comment: https://github.com/mui/mui-x/pull/14812/files/5355f67ffe094f194dc96879526d4dc030323c55#r1797042420.