Skip to content

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Sep 26, 2024

Results:

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Sep 26, 2024
@mui-bot
Copy link

mui-bot commented Sep 26, 2024

Netlify deploy preview

https://deploy-preview-43889--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 632de3d

@Janpot Janpot marked this pull request as ready for review September 26, 2024 08:59
@Janpot Janpot requested a review from a team September 26, 2024 08:59
Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be documented somewhere?

Make it possible to scope a single test in running test:regressions. Just add route = [''] at https://github.com/Janpot/material-ui/blob/632de3d7de97eadb3cc225aca5a3e3a4ba25fb10/test/regressions/index.test.js#L51

@Janpot
Copy link
Member Author

Janpot commented Sep 30, 2024

Should this be documented somewhere?

I think we can document it if we add specific API for it. The "feature" is more a side-effect of the changes I did to optimize them.

@Janpot Janpot merged commit 65efa9f into mui:master Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants