[material-ui] Change React.ReactElement<any,any> type from any to unknown #43358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
changed the title
Netlify deploy previewhttps://deploy-preview-43358--material-ui.netlify.app/ Bundle size report |
DiegoAndai
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Thanks for taking this @sai6855!
I could find other instances of ReactElement<any> still present. No need to cover them in this PR, but
- If we don't cover all cases, we should remove the "close" keyword in the description.
- If you wish to close the issue in this PR, then we should cover all cases. If you do, then skip the
base/andjoy/.
Whatever option you prefer, let me know 😊
Ah okay, I've changed |
1 task
|
@DiegoAndai opened follow up PR for some of left over instances #43402 |
aarongarciah
pushed a commit
to aarongarciah/material-ui
that referenced
this pull request
Aug 26, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #42380
since no one has taken up the issue since last 3 months, i opened PR fixed it