[material-ui][Autocomplete] Remove autocomplete warning regarding value not equal to option #43314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
type: bug
Netlify deploy previewBundle size report |
Member
aarongarciah
left a comment
aarongarciah
left a comment
There was a problem hiding this comment.
I'll leave the final approval to @michaldudak or @DiegoAndai who probably have more context.
Co-authored-by: Aarón García Hervás <[email protected]> Signed-off-by: Zeeshan Tamboli <[email protected]>
2 tasks
michaldudak
approved these changes
Aug 16, 2024
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
Just one nit. Aside from it, I'm OK with this change.
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Zeeshan Tamboli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29727.
Users have raised concerns in #29727 and #18514 that the warning is more problematic than helpful. We remove the warning and document when to use the
isOptionEqualToValueprop instead.