Skip to content

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Aug 14, 2024

Isolate some of the breaking changes introduced in #43135

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Aug 14, 2024
@Janpot Janpot changed the title [core] Update eslint-plugin-jsx-a11y [core] Update eslint-plugin-jsx-a11y Aug 14, 2024
@mui-bot
Copy link

mui-bot commented Aug 14, 2024

Netlify deploy preview

https://deploy-preview-43292--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b387a72

@Janpot Janpot marked this pull request as ready for review August 14, 2024 09:29
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library was about to be updated in #39752, but blocked by an issue mentioned here. See the issue: jsx-eslint/eslint-plugin-jsx-a11y#959. Shouldn't the rule only apply to interactive elements, as per the docs? In that case, shouldn't it not fail for the th table header element?

@Janpot
Copy link
Member Author

Janpot commented Aug 14, 2024

You are right, I acted too fast, thanks for catching it. Perhaps we can add th to the ignore list instead?

@ZeeshanTamboli
Copy link
Member

Perhaps we can add th to the ignore list instead?

Shouldn't th be ignored by ESLint by default? It's fine with me, but only if the package update is critical.

@Janpot
Copy link
Member Author

Janpot commented Aug 14, 2024

No, it's not critical, I'll pin the dependency version so that we can proceed with the lockfile maintenance PR.

@Janpot Janpot requested a review from ZeeshanTamboli August 15, 2024 20:13
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Update eslint-plugin-jsx-a11y [core] Pin eslint-plugin-jsx-a11y to 6.7 Aug 16, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Pin eslint-plugin-jsx-a11y to 6.7 [core] Pin eslint-plugin-jsx-a11y version to 6.7.1 Aug 16, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Updated the PR title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants