Skip to content

Conversation

@zanivan
Copy link
Collaborator

@zanivan zanivan commented Aug 7, 2024

This PR is to unify and standardize custom themes and its structure across all the templates.

The only difference is that in the Dashboard template, we'll have some extra files for X's components such as DataGrid, DatePicker, TreeView and Charts.

For the structure, I follow the same grouping as Material UI's docs, grouping custom components style by Inputs, DataDisplay, Feedback, Surfaces, Navigation, Layout, Utils:

├── template
│   ├── components
│   │   ├── AppAppBar.tsx
│   │   ├── Chart.tsx
│   │   ├── Drawer.tsx
│   │   └── ...
│   ├── theme
│   │   ├── customizations
│   │   │   ├── index.tsx
│   │   │   ├── inputs.tsx
│   │   │   ├── dataDisplay.tsx
│   │   │   ├── feedback.tsx
│   │   │   ├── surfaces.tsx
│   │   │   └── ...
│   │   ├── getTemplateTheme.tsx
│   │   └── themePrimitives.tsx
│   ├── Template.tsx
│   └── README.md

👉 https://deploy-preview-43220--material-ui.netlify.app/material-ui/getting-started/templates/

@zanivan zanivan added docs Improvements or additions to the documentation. package: material-ui design This is about UI or UX design, please involve a designer. labels Aug 7, 2024
@zanivan zanivan self-assigned this Aug 7, 2024
@mui-bot
Copy link

mui-bot commented Aug 7, 2024

Netlify deploy preview

https://deploy-preview-43220--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3e5adcd

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 8, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 9, 2024
@aarongarciah
Copy link
Member

@zanivan I rebased on top of next to solve a CI issue.

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Note: I haven't reviewed every single file, but overall looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design This is about UI or UX design, please involve a designer. docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants