[mui-utils][test] Remove usages of deprecated react-dom APIs #42780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
test
package: utils
15 tasks
Netlify deploy previewhttps://deploy-preview-42780--material-ui.netlify.app/ Bundle size report |
aarongarciah
force-pushed
the
remove-react-dom-deprecated-apis
branch
from
0312f13 to
c16bd9f
Compare
aarongarciah
force-pushed
the
remove-react-dom-deprecated-apis
branch
from
c16bd9f to
21d1ff5
Compare
DiegoAndai
reviewed
Jun 28, 2024
Member
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
Getting closer and closer to React 18.3 🎉
packages/mui-utils/src/elementAcceptingRef/elementAcceptingRef.test.tsx
Outdated
Show resolved
Hide resolved
packages/mui-utils/src/elementAcceptingRef/elementAcceptingRef.test.tsx
Outdated
Show resolved
Hide resolved
aarongarciah
added
the
needs cherry-pick
Member
Author
|
@DiegoAndai ready for the last pass |
Member
Author
|
Oops, one sec, I need to remove a spare |
Member
Author
|
Now is ready |
13 tasks
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #42047, we need to remove
react-domdeprecated APIs, namely,renderandunmountComponentAtNode. This PR replaces these APIs withcreateRenderer, our React Testing Library wrapper.