Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented May 9, 2024

Cherry-pick of #41781

…ment for small autocomplete (#41781)

Co-authored-by: ZeeshanTamboli <[email protected]>
@github-actions github-actions bot added cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. design This is about UI or UX design, please involve a designer. needs cherry-pick The PR should be cherry-picked to master after merge. package: material-ui labels May 9, 2024
@ZeeshanTamboli ZeeshanTamboli removed the needs cherry-pick The PR should be cherry-picked to master after merge. label May 9, 2024
@mui-bot
Copy link

mui-bot commented May 9, 2024

Netlify deploy preview

https://deploy-preview-42176--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 0928812

@ZeeshanTamboli ZeeshanTamboli reopened this May 9, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit c44cb3f into master May 9, 2024
@ZeeshanTamboli ZeeshanTamboli deleted the cherry-pick-41781 branch May 9, 2024 10:11
@DiegoAndai
Copy link
Member

I'm not sure it was necessary to cherry-pick this 🤔 We should only cherry-pick urgent fixes.

Was there a particular reason to do it?

@ZeeshanTamboli
Copy link
Member

I'm not sure it was necessary to cherry-pick this 🤔 We should only cherry-pick urgent fixes.

Was there a particular reason to do it?

The user is using Material UI version 5. I wasn't aware that only urgent fixes, like regressions, are allowed to be cherry-picked. I think we should continue to support fixes on v5 at least until v6 is close to a stable release (maybe by the end of the beta phase?). Developers won't be migrating so early in production applications. From my experience working on GitHub issues, I've seen developers still migrating from v4 to v5. What are your thoughts?

@DiegoAndai
Copy link
Member

I think we should continue to support fixes on v5 at least until v6 is close to a stable release

Yeah, you're right. Let's go with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. design This is about UI or UX design, please involve a designer. scope: autocomplete Changes related to the autocomplete. This includes ComboBox.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants