[material-ui][Autocomplete] Fix the options list being added to the DOM in freeSolo mode even when there are no options, causing style problems
#41300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding condition to add popper to DOM only when the loading is happening or options are greater than 0
Bringing out the Popper container to a function and adding the popper to every condition, so that we can add a condition not to show popper when options are empty and loading is false
Netlify deploy previewhttps://deploy-preview-41300--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
1 task
danilo-leal
changed the title
danilo-leal
added
package: material-ui
scope: autocomplete
ZeeshanTamboli
requested changes
Mar 2, 2024
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
@rakeshmusturi Thanks for the pull request. The AutocompletePopper and AutocompletePaper components are shared among all three conditions. Can you consolidate them in one place for reuse? Also, please address the failing CI.
ZeeshanTamboli
changed the title
freeSolo mode, causing style problems
ZeeshanTamboli
changed the title
freeSolo mode, causing style problems freeSolo mode even when there are no options, causing style problems
ZeeshanTamboli
approved these changes
Mar 7, 2024
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
@rakeshmusturi Thanks for the pull request. I've made the expected changes, and it looks good to me.
cipherlogs
pushed a commit
to cipherlogs/material-ui
that referenced
this pull request
Mar 8, 2024
…OM in `freeSolo` mode even when there are no options, causing style problems (mui#41300) Co-authored-by: ZeeshanTamboli <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
…OM in `freeSolo` mode even when there are no options, causing style problems (mui#41300) Co-authored-by: ZeeshanTamboli <[email protected]>
1 task
This was referenced May 25, 2024
This was referenced May 25, 2024
This was referenced Jun 15, 2024
This was referenced Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40843
Adding condition to add popper to DOM only when the loading is happening or options are greater than 0