[material-ui][PaginationItem] Add codemod for deprecated classes #41145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
package: material-ui
package: codemod
Netlify deploy previewBundle size report |
DiegoAndai
reviewed
Feb 19, 2024
Member
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
Looks good @sai6855!
Only have one comment.
| npx @mui/codemod@latest deprecations/pagination-item-classes <path> | ||
| ``` | ||
|
|
||
| ### .MuiPaginationItem-textPrimary |
Member
There was a problem hiding this comment.
We should summarize all PaginationItem's composed classes deprecations into a single section. Otherwise, this file will get huge 😅. We can do:
### Composed CSS classes
The following CSS classes were deprecated:
- `.MuiPaginationItem-textPrimary` deprecated in favor of `.MuiPaginationItem-text.MuiPaginationItem-colorPrimary`
- `.MuiPaginationItem-outlinedPrimary` deprecated in favor of `.MuiPaginationItem-outlined.MuiPaginationItem-colorPrimary`
- ...
Here's an example on how to migrate:
(Example diffs for `.MuiPaginationItem-textPrimary`)
Contributor
Author
There was a problem hiding this comment.
what do you think of this format https://deploy-preview-41145--material-ui.netlify.app/material-ui/migration/migrating-from-deprecated-apis/#paginationitem
Member
There was a problem hiding this comment.
I would remove the list to be more concise:
### Composed CSS classes
The CSS classes that composed the `variant` and `color` prop values were removed. Here's how to migrate:
(... diffs)
sai6855
force-pushed
the
pagination-item-codemode-class
branch
from
ebfabe0 to
e9656ce
Compare
DiegoAndai
reviewed
Feb 20, 2024
| +.MuiPaginationItem-text.MuiPaginationItem-colorSecondary | ||
| -.MuiPaginationItem-outlinedSecondary | ||
| +.MuiPaginationItem-outlined.MuiPaginationItem-colorSecondary | ||
| /> |
| - `.MuiPaginationItem-textSecondary` deprecated in favor of `.MuiPaginationItem-text.MuiPaginationItem-colorSecondary` | ||
| - `.MuiPaginationItem-outlinedSecondary` deprecated in favor of `.MuiPaginationItem-outlined.MuiPaginationItem-colorSecondary` | ||
|
|
||
| Here's an example on how to migrate: |
Member
There was a problem hiding this comment.
Suggested change
| Here's an example on how to migrate: | |
| Here's how to migrate: |
DiegoAndai
approved these changes
Feb 20, 2024
This was referenced Feb 20, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #40417
preview: https://deploy-preview-41145--material-ui.netlify.app/material-ui/migration/migrating-from-deprecated-apis