Skip to content

Conversation

@michaldudak
Copy link
Member

Created the @mui/internal-scripts package with its first subpackage: typescript-to-proptypes.

@michaldudak michaldudak added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Feb 13, 2024
@michaldudak michaldudak requested a review from a team February 13, 2024 13:07
@mui-bot
Copy link

mui-bot commented Feb 13, 2024

Netlify deploy preview

https://deploy-preview-41079--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 80f6f37

- 'docs'
- 'test'
- 'apps/*'
- 'internal/*'
Copy link
Member

@Janpot Janpot Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we will collect al internal packages? i.e. all @mui/internal- packages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the idea. This could also be named internal-packages if you like, but internal matches the package prefix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 got it.

Up to you, I don't have a strong opinion on this. I we end up renaming it, I'd be more leaning towards packages-internal as that will place it next to the packages folder in the file explorer.

@michaldudak michaldudak force-pushed the ttp-to-internal-scripts branch from 99dcea9 to 01931c2 Compare February 14, 2024 09:00
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more inclined towards packages-internal, but at your own discretion

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Feb 14, 2024
@michaldudak
Copy link
Member Author

I don't have a strong preference, so let it be packages-internal.

@michaldudak
Copy link
Member Author

MUI X integration: mui/mui-x#12142

@michaldudak michaldudak marked this pull request as ready for review February 20, 2024 13:20
@michaldudak michaldudak changed the title [code-infra] Move typescript-to-packages to internal-scripts package [code-infra] Move typescript-to-proptypes to internal-scripts package Feb 20, 2024
@michaldudak michaldudak merged commit 47e1cf9 into mui:master Feb 20, 2024
@michaldudak michaldudak deleted the ttp-to-internal-scripts branch February 20, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants