Skip to content

Conversation

@mapache-salvaje
Copy link
Contributor

WIP

See: #39637 (comment)

This PR brings the Box content back to the Material UI and Joy UI docs, instead of redirecting users to the MUI System docs. I'm also taking the opportunity to do another pass on the content here, to improve the demos and bring the format closer to the latest version of the Material UI demo pages.

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation. component: Box The React component. support: docs-feedback Feedback from documentation page. labels Jan 15, 2024
@mui-bot
Copy link

mui-bot commented Jan 15, 2024

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 9, 2024
githubLabel: 'component: Box'
---

<!-- This page's content is duplicated (with some product-specific details) across the Material UI, Joy UI, and MUI System docs. Any changes should be applied to all three pages at the same time. -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we feel about comments like this? It was the best way I could think of to draw attention to this fact to try to keep these pages in sync.

@mapache-salvaje
Copy link
Contributor Author

One thing I still don't love is the need to discuss MUI System in the Material UI and Joy UI pages. It's confusing! I shouldn't need to know about this whole other product to use this component. I'm not sure how to address this.

@mapache-salvaje mapache-salvaje marked this pull request as ready for review February 12, 2024 17:11
@mapache-salvaje
Copy link
Contributor Author

Hey @zanivan ! 👋 I'm pretty much done with the copy revisions in this PR. Feel free to pitch in if you have any ideas to make the demos more interesting! We could use a demo for the Introduction section in particular.

Copy link
Collaborator

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me—straightforward to understand and go through! 🤙 I supposed the mentions of MUI System in both the Material and Joy UI docs become less weird if we (over time) reinforce that these packages were made optimized for this particular styling package (and how they play extra-nicely together). This may be understood already, but it feels more implicit than the opposite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Box The React component. docs Improvements or additions to the documentation. support: docs-feedback Feedback from documentation page.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants