[system] Catch localStorage unavailability #34027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
approved these changes
Aug 22, 2022
Member
There was a problem hiding this comment.
This looks good to me. Thanks for the help @jsakas
I think the result would be the same as https://github.com/mui/mui-x/blob/6be8bcbac5c6df70bf476005383df8731135f573/packages/grid/x-data-grid/src/utils/utils.ts#L13.
siriwatknp
added
type: bug
1 task
oliviertassinari
added
type: bug
oliviertassinari
changed the title
oliviertassinari
removed
the
type: regression
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use Joy UI to build a Figma plugin, but localStorage is not available in this environment and so the library could not be used. This would also be the case for private mode as mentioned in #33853
This PR just wraps all of the calls in a try / catch, which was how one call was already handled.
Another solution might be to create our own class, similar to a polyfill, that wraps localStorage and proxies commands with a try catch, so the code calling localStorage becomes smaller and potentially more readable.
I didn't not want to make too many assumptions about how MUI team wants to resolve the bug so let me know what you think and I will update if needed.
closes #33853