Skip to content

Conversation

@flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 5, 2022

Before:

image

After:

image

Maybe we should unify with the new doc copy feature

@flaviendelangle flaviendelangle added the website Pages that are not documentation-related, marketing-focused. label May 5, 2022
@flaviendelangle flaviendelangle self-assigned this May 5, 2022
@mui-bot
Copy link

mui-bot commented May 5, 2022

No bundle size changes

Generated by 🚫 dangerJS against 37cda77

Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's related to this PR, but this page crashes for me:
https://deploy-preview-32638--material-ui.netlify.app/core/

Copy link
Collaborator

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-05-05 at 13 54 54

I guess that the interaction and visuals should be the same as it is on the doc's code blocks — on the marketing pages it is being rendered as a default HTML button 🤔

@flaviendelangle flaviendelangle merged commit 989b7a9 into mui:master May 6, 2022
@flaviendelangle flaviendelangle deleted the highlighted-code-space branch May 6, 2022 07:00
@flaviendelangle
Copy link
Member Author

I merge as is since it's a super trivial fix that we can release quickly.
But I agree that we should unify the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website Pages that are not documentation-related, marketing-focused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants