Skip to content

[InputBase] Fix autofill issue #28070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2021
Merged

[InputBase] Fix autofill issue #28070

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1da9c6
Fix autofill issue
mnajdova Aug 31, 2021
4f9d945
Update packages/material-ui/src/InputBase/InputBase.js
mnajdova Aug 31, 2021
ed81296
Use React.memo
mnajdova Aug 31, 2021
daa0a0e
Merge branch 'feat/input-base-auto-fill' of https://github.com/mnajdo…
mnajdova Aug 31, 2021
bf435d2
Merge branch 'next' into feat/input-base-auto-fill
mnajdova Sep 1, 2021
01d62f7
Sebastian's review
mnajdova Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/material-ui/src/InputBase/InputBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,16 @@ export const InputBaseComponent = styled('input', {
}),
};
});

const InputGlobalStyles = React.memo(() => (
<GlobalStyles
styles={{
'@keyframes mui-auto-fill': { from: { display: 'block' } },
'@keyframes mui-auto-fill-cancel': { from: { display: 'block' } },
}}
/>
));

/**
* `InputBase` contains as few styles as possible.
* It aims to be a simple building block for creating an input.
Expand Down Expand Up @@ -483,12 +493,7 @@ const InputBase = React.forwardRef(function InputBase(inProps, ref) {

return (
<React.Fragment>
<GlobalStyles
styles={{
Copy link
Member

@eps1lon eps1lon Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just learned that @babel/plugin-transform-constant-elements deopts mutable props. This unlocks a bunch of optimizations actually since we treat props as immutable all the time. Will investigate in a follow-up.

'@keyframes mui-auto-fill': {},
'@keyframes mui-auto-fill-cancel': {},
}}
/>
<InputGlobalStyles />
<Root
{...rootProps}
{...(!isHostComponent(Root) && {
Expand Down