-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[CSS] Fix invalid colorAdjust property #20795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds the correct css color adjust prop. You can test this error https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.a11ywatch.com
Details of bundle changes.Comparing: 70e8e96...71fd30d Details of page changes
|
Just to make sure I am following correctly. So we can just use |
|
@j-mendez My only point of concern is around: Are we sure the report https://validator.w3.org does is accurate? Should the fix be on https://github.com/w3c/css-validator side? |
|
Opened w3c/css-validator#276 |
I tested this locally in chrome and it has no affect without the vendor prefix. |
|
For server-side rendering you probably want to run auto-prefixer on the generated CSS. Otherwise the initial CSS might not be supported in all of your targeted browsers. Once the UI is hydrated JSS correctly prefixes this property with In firefox this property is untouched since firefox supports Closing in favor of w3c/css-validator#276 since there's nothing we can do. |


This adds the correct css color adjust prop.
https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.a11ywatch.com
