[docs] Add more props documentation to IntelliSense #20264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: f46c1e6...dbd1d3e Details of page changes
|
Member
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
This is an exciting change :)
This is why it's actually bad to rely on it too much. Goes against one of the strengths of TS: refactoring
Member
Author
|
Need to go over this again just in case. Though I'm quite confident this is fine since our type test coverage is a lot better. |
oliviertassinari
approved these changes
Mar 24, 2020
eps1lon
force-pushed
the
docs/more-proptypes-from-typescript
branch
from
38645c2 to
9212d46
Compare
eps1lon
commented
Mar 25, 2020
| | Name | Type | Default | Description | | ||
| |:-----|:-----|:--------|:------------| | ||
| | <span class="prop-name">anchorEl</span> | <span class="prop-type">object<br>| func</span> | | The DOM element used to set the position of the menu. | | ||
| | <span class="prop-name">anchorEl</span> | <span class="prop-type">func<br>| Element</span> | | The DOM element used to set the position of the menu. | |
Member
Author
There was a problem hiding this comment.
Even the markdown docs get an improvement.
eps1lon
commented
Mar 25, 2020
Comment on lines
-93
to
-96
| /** | ||
| * @ignore | ||
| */ | ||
| onKeyDown: PropTypes.func, |
Member
Author
There was a problem hiding this comment.
onKeyDown and onBlur were unused. Since we spread them to FormGroup the validation still takes place.
Member
|
Yeah 🚀! A small detail that will make a difference. It would be interesting to look at the steps required to roll this approach to 100% of our components. |
Member
Author
|
@oliviertassinari More or less already done locally. Just rolling these out in digestible chunks to |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
2 tasks
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--patterntoyarn proptypes:yarn proptypes --pattern Buttononly generates proptypes forButtonandButtonBaseExpansionPanelActions,ExpansionPanelDetailsno longer issue proptypes warnings on emtpy children. These components work perfectly well without them.