Skip to content

[TreeView] Fix inconsistent focus for programmatically focused tree item #20237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020
Merged

[TreeView] Fix inconsistent focus for programmatically focused tree item #20237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/material-ui-lab/src/TreeItem/TreeItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ const TreeItem = React.forwardRef(function TreeItem(props, ref) {
};

const handleFocus = (event) => {
if (!focused && tabbable) {
if (!focused && event.currentTarget === event.target) {
focus(nodeId);
}

Expand Down
20 changes: 20 additions & 0 deletions packages/material-ui-lab/src/TreeItem/TreeItem.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,26 @@ describe('<TreeItem />', () => {

expect(getByTestId('two')).to.have.focus;
});

it('should work with programmatic focus', () => {
const { getByTestId } = render(
<React.Fragment>
{/* eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex */}
<div data-testid="start" tabIndex={0} />
<TreeView>
<TreeItem nodeId="1" label="one" data-testid="one" />
<TreeItem nodeId="2" label="two" data-testid="two" />
</TreeView>
</React.Fragment>,
);

expect(getByTestId('one')).to.have.attribute('tabindex', '0');
expect(getByTestId('two')).to.have.attribute('tabindex', '-1');

getByTestId('two').focus();
expect(getByTestId('one')).to.have.attribute('tabindex', '-1');
expect(getByTestId('two')).to.have.attribute('tabindex', '0');
});
});

describe('Navigation', () => {
Expand Down