Skip to content

[Drawer] Add a comment for clarity on the styling of height of the toolbar #19934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 3, 2020
Merged

[Drawer] Add a comment for clarity on the styling of height of the toolbar #19934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b9124b8
Update ClippedDrawer.js
smerriman18 Mar 2, 2020
031fd30
Update ClippedDrawer.tsx
smerriman18 Mar 2, 2020
785144e
Update MiniDrawer.js
smerriman18 Mar 2, 2020
ff2575a
Update MiniDrawer.tsx
smerriman18 Mar 2, 2020
78188b7
Add comment for clarity
smerriman18 Mar 2, 2020
bdf599b
Add comment for clarity
smerriman18 Mar 2, 2020
d5defc4
Add comment for clarity
smerriman18 Mar 2, 2020
804cf72
Add comment for clarity
smerriman18 Mar 2, 2020
51a691a
Add comment for clarity
smerriman18 Mar 2, 2020
85b4f2f
Add comment for clarity
smerriman18 Mar 2, 2020
46ca595
Add comment for clarity
smerriman18 Mar 2, 2020
d49d15c
Add comment for clarity
smerriman18 Mar 2, 2020
612c313
Add comment for clarity
smerriman18 Mar 2, 2020
1cb77e3
Add comment for clarity
smerriman18 Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/ClippedDrawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const useStyles = makeStyles(theme => ({
flexGrow: 1,
padding: theme.spacing(3),
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
}));

Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/ClippedDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const useStyles = makeStyles((theme: Theme) =>
flexGrow: 1,
padding: theme.spacing(3),
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
}),
);
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/MiniDrawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ const useStyles = makeStyles(theme => ({
alignItems: 'center',
justifyContent: 'flex-end',
padding: theme.spacing(0, 1),
// necessary for content to be below app bar
...theme.mixins.toolbar,
},
content: {
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/MiniDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ const useStyles = makeStyles((theme: Theme) =>
alignItems: 'center',
justifyContent: 'flex-end',
padding: theme.spacing(0, 1),
// necessary for content to be below app bar
...theme.mixins.toolbar,
},
content: {
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PermanentDrawerLeft.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const useStyles = makeStyles(theme => ({
drawerPaper: {
width: drawerWidth,
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
content: {
flexGrow: 1,
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PermanentDrawerLeft.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const useStyles = makeStyles((theme: Theme) =>
drawerPaper: {
width: drawerWidth,
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
content: {
flexGrow: 1,
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PermanentDrawerRight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const useStyles = makeStyles(theme => ({
drawerPaper: {
width: drawerWidth,
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
content: {
flexGrow: 1,
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PermanentDrawerRight.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const useStyles = makeStyles((theme: Theme) =>
drawerPaper: {
width: drawerWidth,
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
content: {
flexGrow: 1,
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PersistentDrawerLeft.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const useStyles = makeStyles(theme => ({
display: 'flex',
alignItems: 'center',
padding: theme.spacing(0, 1),
// necessary for content to be below app bar
...theme.mixins.toolbar,
justifyContent: 'flex-end',
},
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PersistentDrawerLeft.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const useStyles = makeStyles((theme: Theme) =>
display: 'flex',
alignItems: 'center',
padding: theme.spacing(0, 1),
// necessary for content to be below app bar
...theme.mixins.toolbar,
justifyContent: 'flex-end',
},
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PersistentDrawerRight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const useStyles = makeStyles(theme => ({
display: 'flex',
alignItems: 'center',
padding: theme.spacing(0, 1),
// necessary for content to be below app bar
...theme.mixins.toolbar,
justifyContent: 'flex-start',
},
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/PersistentDrawerRight.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const useStyles = makeStyles((theme: Theme) =>
display: 'flex',
alignItems: 'center',
padding: theme.spacing(0, 1),
// necessary for content to be below app bar
...theme.mixins.toolbar,
justifyContent: 'flex-start',
},
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/ResponsiveDrawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const useStyles = makeStyles(theme => ({
display: 'none',
},
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
drawerPaper: {
width: drawerWidth,
Expand Down
1 change: 1 addition & 0 deletions docs/src/pages/components/drawers/ResponsiveDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const useStyles = makeStyles((theme: Theme) =>
display: 'none',
},
},
// necessary for content to be below app bar
toolbar: theme.mixins.toolbar,
drawerPaper: {
width: drawerWidth,
Expand Down