[system] Array reject on spacing transformation fixed #19900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weslenng
changed the title
|
@material-ui/core: parsed: +0.01% , gzip: -0.15% 😍 Details of bundle changes.Comparing: e6dae39...79659a3
|
oliviertassinari
added
the
scope: system
oliviertassinari
approved these changes
Feb 29, 2020
|
@weslenng I have updated the test case a bit to match the new logic. Thanks for the effort :) |
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
1 task
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than adding and testing the correction purposed by @oliviertassinari, I had to add the following code stretch
export * from './spacing';in the filepackages/material-ui-system/src/index.jsin order to build the module.It doesn't seem like a problem, but it seems important to quote those to avoid any type of side-effect.
Closes #19872