Skip to content

[Autocomplete] Fix double change event issue #18786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2019
Merged

[Autocomplete] Fix double change event issue #18786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1f369f
Fixed issue #18344 and added test case for it
tplai Dec 11, 2019
df6ecf7
Removed extraneous bracket
tplai Dec 11, 2019
48dd4a2
Defined handleChange (oops)
tplai Dec 11, 2019
38d567c
Used deep.equal in expect to verify Autocomplete value
tplai Dec 11, 2019
6153415
Removed extra set of brackets from assertion
tplai Dec 11, 2019
9ca23a4
remove redundant assertion
oliviertassinari Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/material-ui-lab/src/Autocomplete/Autocomplete.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,4 +720,26 @@ describe('<Autocomplete />', () => {
expect(options.length).to.equal(1);
});
});

describe('prop: freeSolo', () => {
it('pressing twice enter should not call onChange listener twice', () => {
const handleChange = spy();
const options = [{ name: 'foo' }];
render(
<Autocomplete
freeSolo
onChange={handleChange}
options={options}
getOptionLabel={option => option.name}
renderInput={params => <TextField {...params} autoFocus />}
/>,
);
fireEvent.keyDown(document.activeElement, { key: 'ArrowDown' });
fireEvent.keyDown(document.activeElement, { key: 'Enter' });
expect(handleChange.callCount).to.equal(1);
expect(handleChange.args[0][1]).to.deep.equal(options[0]);
fireEvent.keyDown(document.activeElement, { key: 'Enter' });
expect(handleChange.callCount).to.equal(1);
});
});
});
2 changes: 1 addition & 1 deletion packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ export default function useAutocomplete(props) {
inputRef.current.value.length,
);
}
} else if (freeSolo && inputValue !== '') {
} else if (freeSolo && inputValueFilter !== '') {
selectNewValue(event, inputValue);
}
break;
Expand Down